Quantcast

documentation for defaultStatementTimeout and timeout is missing units

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

documentation for defaultStatementTimeout and timeout is missing units

BusyByte
You should add to the user documentation that both of these are
seconds and not milliseconds.
I had it set to 20000 thinking it was milliseconds and then wasn't
setting timeouts after 60 seconds as expected.
I figured out what it is being set on setQueryTimeout but the point of
ORM is to make it easier to use.
I shouldn't have to go refernce the javadoc for setQueryTimeout to
figure out how to use the timeouts in MyBatis.
Can you please update the MyBatis javadoc and user documentation (pdf)
to include units for timeout?

Thanks,
BB
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: documentation for defaultStatementTimeout and timeout is missing units

Eduardo Macarron
updated in trunk, will see online in a short time

2012/3/2 BusyByte <[hidden email]>:

> You should add to the user documentation that both of these are
> seconds and not milliseconds.
> I had it set to 20000 thinking it was milliseconds and then wasn't
> setting timeouts after 60 seconds as expected.
> I figured out what it is being set on setQueryTimeout but the point of
> ORM is to make it easier to use.
> I shouldn't have to go refernce the javadoc for setQueryTimeout to
> figure out how to use the timeouts in MyBatis.
> Can you please update the MyBatis javadoc and user documentation (pdf)
> to include units for timeout?
>
> Thanks,
> BB
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: documentation for defaultStatementTimeout and timeout is missing units

Jeremy Landis
I know this is old but wanted to bring it up.  Although the documentation states these values are in seconds since this request, all examples show huge values (ie 25000 and 20000).  I verified this in the most recent 3.2.0 snapshot.  Can the example configurations be changed to represent something a little more reasonable and maybe even have an additional comment noting that it is in seconds?  I'm guessing most new users will simply see the sample and plug it in place.  We did the same thing and just now realized the issue.

On Friday, March 2, 2012 2:18:47 PM UTC-5, Eduardo wrote:
updated in trunk, will see online in a short time

2012/3/2 BusyByte <<a href="javascript:" target="_blank" gdf-obfuscated-mailto="43rRUkATzeEJ">shawnd...@...>:


> You should add to the user documentation that both of these are
> seconds and not milliseconds.
> I had it set to 20000 thinking it was milliseconds and then wasn't
> setting timeouts after 60 seconds as expected.
> I figured out what it is being set on setQueryTimeout but the point of
> ORM is to make it easier to use.
> I shouldn't have to go refernce the javadoc for setQueryTimeout to
> figure out how to use the timeouts in MyBatis.
> Can you please update the MyBatis javadoc and user documentation (pdf)
> to include units for timeout?
>
> Thanks,
> BB

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate
star

Re: documentation for defaultStatementTimeout and timeout is missing units

Eduardo Macarron
Done. Thanks for the hint!

2012/12/4 Jeremy Landis <[hidden email]>:
> 20000
Loading...